Repository navigation
fix: reject saving a consumed download again - #708
Merged
Merged
Conversation
|
Warning Review limit reachedThis organization requires a seat for paid usage-based reviews, including automatic and on-demand reviews. Ask an admin to assign a seat or enable paid usage-based reviews for users without a seat in Billing. Next included review available in 32 minutes. View limit details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Refs #703 (C56 only).
Changes
Track consumption of a
DownloadedFileresponse and reject another save with a clearRuntimeErrordirecting callers to request a new download. Rejectsave_to()before it opens or truncates a destination. Mark the response consumed when the transfer starts.Add regression coverage for empty and nonempty streamed responses, destination preservation, and both save entry points. Update the existing C56 audit test to the clear-error contract permitted by #703. Add a bugfix changelog fragment.
Verification
StreamConsumedErrorfor nonempty streamed content.noxfile.py; the same failure was reproduced from master. Left unchanged to keep this PR scoped to C56.